http2: add headersDistinct to Http2ServerRequest fixes #64060#64071
Open
Shivay-98 wants to merge 1 commit into
Open
http2: add headersDistinct to Http2ServerRequest fixes #64060#64071Shivay-98 wants to merge 1 commit into
Shivay-98 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
pimterry
reviewed
Jun 30, 2026
pimterry
left a comment
pimterry
left a comment
Member
There was a problem hiding this comment.
Nice work, thanks @Shivay-98!
There's a few JS linting issues to fix here (you can check locally with make lint). For the commit linting issue, you'll need to run git commit --amend -s to update the commit with the signed-off signature, and then force-push to update the commit here.
It'd be good to also include this change in the docs, in the compat API section in http2.md.
| const kSetHeader = Symbol('setHeader'); | ||
| const kAppendHeader = Symbol('appendHeader'); | ||
| const kAborted = Symbol('aborted'); | ||
| const kHeadersDistinct = Symbol('kHeadersDistinct'); |
Member
There was a problem hiding this comment.
Nit: for symbols, generally the name doesn't have the k prefix - it's just the meaningful string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds headersDistinct to Http2ServerRequest to improve parity with
http.IncomingMessage.
The implementation mirrors IncomingMessage.headersDistinct by
lazily constructing a null-prototype object from rawHeaders and
preserving all header values as arrays.
Includes tests covering:
fixes
headersDistinctfor http2 requests #64060